Bson specification testing #1820

rozza · 2025-10-09T10:51:40Z

Moved specifications submodule out of driver-core into a testing directory.
Deleted old copy of bson specification tests and updated to use the submodule
Fixed Json output for positive exponents to match the the extended json specification

Added test exceptions to BinaryVectorGenericBsonTest
Added BsonBinaryVector prose tests
Added extra regression tests to ensure both explicit and implicit doubles with positive exponets parse as expected.

JAVA-5877
JAVA-5779
JAVA-5782
JAVA-5652

Copilot

Pull Request Overview

This PR reorganizes specification testing by moving the MongoDB specifications submodule from driver-core to a shared testing directory, updates JSON output for positive exponents to match the extended JSON specification, and adds comprehensive testing for BsonBinaryVector functionality.

Moved specifications submodule from driver-core to shared testing directory for better organization
Fixed JSON output to include explicit "+" signs for positive exponents in extended JSON
Added comprehensive testing for BsonBinaryVector including prose tests and enhanced validation

Reviewed Changes

Copilot reviewed 47 out of 49 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
.gitmodules	Updated submodule path from driver-core to testing directory
bson/build.gradle.kts	Added test resource processing to include shared testing resources
driver-core/build.gradle.kts	Added test resource processing to include shared testing resources
bson/src/main/org/bson/json/*.java	Modified double converters to use consistent JSON formatting with explicit positive exponents
bson/src/main/org/bson/BinaryVector.java	Added validation logging for non-zero padding bits
bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java	Enhanced test coverage and updated to use new spec test location
bson/src/test/unit/org/bson/*.java	Updated test references to use new specification test helper method
bson/src/test/resources/bson*/	Removed old BSON specification test files (now using submodule)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

bson/src/main/org/bson/json/JsonDoubleHelper.java

bson/src/main/org/bson/BinaryVector.java

Moved specifications submodule out of driver-core into a testing directory. Deleted old copy of bson specification tests and updated to use the submodule Fixed Json output for positive exponents to match the the extended json specification Added test exceptions to BinaryVectorGenericBsonTest Added BsonBinaryVector prose tests Added extra regression tests to ensure both explicit and implicit doubles with positive exponets parse as expected. JAVA-5877 JAVA-5779 JAVA-5782 JAVA-5652

Co-authored-by: Copilot <[email protected]>

vbabanin · 2025-10-20T05:38:57Z

bson/src/test/unit/org/bson/BinaryVectorProseTest.java

+
+    @DisplayName("Treatment of non-zero ignored bits: 2. Decoding")
+    @Test
+    void decodingWithNonZeroIgnoredBits() {


The BinaryVectorTest only covers use-cases for creating BinaryVectors from constructor methods of BinaryVector API.

We have a separate class BsonBinaryTest for decoding tests with methods:
shouldDecodeInt8Vector, shouldEncodePackedBitVector. I suggest we move decoding test method there to keep them coherent.

Renamed this file to BinaryVectorProseTest as these include the new tests in the spec.

Note there are corpus tests also that cover the BsonBinary api, these prose and extra tests allow for extra testing of the API.

bson/src/test/unit/org/bson/BinaryVectorTest.java

vbabanin · 2025-10-20T05:59:52Z

bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java

+        }
+
+        // TODO JAVA-5848 in 6.0.0 "Padding specified with no vector data PACKED_BIT" will throw an error (currently logs a warning).
+        if (testCase.containsKey("canonical_bson") && !testDescription.equals("Padding specified with no vector data PACKED_BIT")) {


We already maintain a list of ignored tests in TEST_NAMES_TO_IGNORE. Should we move this check to TEST_NAMES_TO_IGNORE to keep it consistent and easier to track?

This would also simplify the method signature by removing the testDescription parameter.

vbabanin · 2025-10-21T04:38:00Z

bson/src/test/unit/org/bson/vector/BinaryVectorTest.java

        BsonArray arrayVector = testCase.getArray("vector");
-        byte expectedPadding = (byte) testCase.getInt32("padding").getValue();
        byte dtypeByte = Byte.decode(testCase.getString("dtype_hex").getValue());


If an error occurs in the test setup (for example, Byte.decode("") throwing an IllegalArgumentException, an intentional mistake in this case), all tests currently pass.

This happens because IllegalArgumentException and IllegalStateException are caught broadly in assertValidationException covering both the setup logic and the SUT, and treated as expected results.

While I see the benefit of a more generalized approach, I think we should assert exceptions only where they’re explicitly expected, as we did previously and still do in runValidTestCase.

That would separate test setup of code under test and reduce the risk of unintentionally masking setup errors as successful test results.

vbabanin · 2025-10-21T05:35:53Z

bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java

+                BinaryVector.packedBitVector(bytes, expectedPadding);
+                break;
+            case FLOAT32:
+                throw new IllegalArgumentException("Float32 is not supported");


Currently, when a JSON test that we don’t support runs through the runner, it throws IllegalArgumentException, which propagates to assertValidationException and is treated as a successful execution.

Since we have a few such unsupported cases (9 in total, with only 4 currently reported as skipped via TEST_NAMES_TO_IGNORE), it could be clearer to surface them as skipped instead.

We could do that by throwing a TestAbortedException, for example: Assumptions.abort(dataType + " is not supported with padding");, so these cases are reported as skipped without implying they passed successfully.

bson/src/main/org/bson/json/JsonDoubleHelper.java

vbabanin · 2025-10-21T06:19:22Z

driver-core/build.gradle.kts

 }

+tasks.processTestResources {
+    from("${rootProject.projectDir}/testing/resources")


Nice! I think, In the future, we could also consider creating a separate module for testing utilities, so shared helpers can be reused across sync, reactive, core, and BSON modules.

Co-authored-by: Viacheslav Babanin <[email protected]>

rozza · 2025-10-21T10:41:21Z

@vbabanin I've updated the names of the tests to be more inline with the spec location and to identify the prose tests.

I also moved the validation to the constructors as it seemed the best place to have it.

rozza

Updated the code

rozza · 2025-10-21T08:38:34Z

bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java

+        }
+
+        // TODO JAVA-5848 in 6.0.0 "Padding specified with no vector data PACKED_BIT" will throw an error (currently logs a warning).
+        if (testCase.containsKey("canonical_bson") && !testDescription.equals("Padding specified with no vector data PACKED_BIT")) {


rozza · 2025-10-21T10:36:56Z

bson/src/test/unit/org/bson/BinaryVectorProseTest.java

+
+    @DisplayName("Treatment of non-zero ignored bits: 2. Decoding")
+    @Test
+    void decodingWithNonZeroIgnoredBits() {


Renamed this file to BinaryVectorProseTest as these include the new tests in the spec.

rozza · 2025-10-21T10:37:19Z

bson/src/test/unit/org/bson/vector/BinaryVectorTest.java

        BsonArray arrayVector = testCase.getArray("vector");
-        byte expectedPadding = (byte) testCase.getInt32("padding").getValue();
        byte dtypeByte = Byte.decode(testCase.getString("dtype_hex").getValue());


rozza · 2025-10-21T10:37:24Z

bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java

+                BinaryVector.packedBitVector(bytes, expectedPadding);
+                break;
+            case FLOAT32:
+                throw new IllegalArgumentException("Float32 is not supported");


rozza requested a review from vbabanin October 9, 2025 10:51

rozza requested a review from a team as a code owner October 9, 2025 10:51

rozza requested a review from Copilot October 9, 2025 10:51

Copilot AI reviewed Oct 9, 2025

View reviewed changes

bson/src/main/org/bson/json/JsonDoubleHelper.java Outdated Show resolved Hide resolved

bson/src/main/org/bson/BinaryVector.java Outdated Show resolved Hide resolved

rozza force-pushed the JAVA-5877 branch from 261dd7f to 36cfff4 Compare October 9, 2025 10:53

rozza and others added 2 commits October 9, 2025 11:54

Update bson/src/main/org/bson/json/JsonDoubleHelper.java

3f54ffc

Co-authored-by: Copilot <[email protected]>

Checkstyle fix

75df9bb

vbabanin reviewed Oct 21, 2025

View reviewed changes

rozza and others added 4 commits October 21, 2025 09:28

Update bson/src/test/unit/org/bson/BinaryVectorTest.java

1287f1b

Co-authored-by: Viacheslav Babanin <[email protected]>

Update bson/src/test/unit/org/bson/BinaryVectorTest.java

024981d

Co-authored-by: Viacheslav Babanin <[email protected]>

Apply suggestion from @vbabanin

16acd75

Co-authored-by: Viacheslav Babanin <[email protected]>

PR updates

89120fd

rozza commented Oct 21, 2025

View reviewed changes

rozza requested a review from vbabanin October 21, 2025 10:44

Bson specification testing #1820

Are you sure you want to change the base?

Bson specification testing #1820

Uh oh!

Conversation

rozza commented Oct 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbabanin Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbabanin Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rozza commented Oct 21, 2025

Uh oh!

rozza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vbabanin Oct 21, 2025 •

edited

Loading

vbabanin Oct 21, 2025 •

edited

Loading